device: avoid direct assignment to device api pointer #26190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is set when the device is defined, and should not be modified. Signed-off-by: Peter Bigot <[email protected]>
This is set when the device is defined, and should not be modified. Signed-off-by: Peter Bigot <[email protected]>
The driver API should be assigned at the time the device is defined. Assigning in the init function is redundant and prevents moving the pointer to a immutable driver structure. Signed-off-by: Peter Bigot <[email protected]>
dcpleung
approved these changes
Jun 15, 2020
mnkp
approved these changes
Jun 15, 2020
MaureenHelm
approved these changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost all drivers use
DEVICE_AND_API_INIT()or a wrapper of that to initialize the device API table pointer. Fix two drivers that assigned to during initialization, and remove documentation that suggests this is appropriate.There is one remaining case that is fixed by "drivers/gpio: Use DEVICE_AND_API_INIT for mmio32 driver" from #24873, but I believe draft process requires @tbursztyka either submit that independently or explicitly grant me permission to cherry-pick it into this (which I'm willing to do).